This repository has been archived by the owner on Nov 14, 2020. It is now read-only.
resource_user: Fix tags/password update. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Updating tags was resetting password (set to empty) I had to update the rabbit-hole library which was in a very old version. So it's quite a big change but this version did not check correctly RMQ API errors. Co-authored-by: Alexander Hellbom <[email protected]>
cyrilgdn
force-pushed
the
update_tags
branch
from
c66a5a1 to
7235f36
Compare
|
Thanks a lot @heimweh , I added you as a co-author to credit the work you've done on that. |
|
Thank you so much @cyrilgdn! 🙏 |
cyrilgdn
added a commit
that referenced
this pull request
Jan 6, 2020
We forgot in PR #31 to do it when changing the version of rabbit-hole
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating tags was resetting password (set to empty)
I had to update the rabbit-hole library which was in a very old version.
So it's quite a big change but this version did not check correctly RMQ API errors.